Skip to content

Use opentelemetry:time::now instead of systemtime (final part) #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Use opentelemetry:time::now instead of systemtime (final part) #2607

merged 2 commits into from
Feb 4, 2025

Conversation

@mohammadVatandoost
Copy link
Contributor

@mohammadVatandoost mohammadVatandoost commented Feb 4, 2025 •
edited by cijothomas
Loading

Fixes #2557
Final 2 for #2557

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner February 4, 2025 22:34
@codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (4a76c96) to head (325387f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-sdk/src/trace/sampler/jaeger_remote/rate_limit.rs 75.0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2607   +/-   ##
=====================================
  Coverage   79.2%   79.2%           
=====================================
  Files        118     118           
  Lines      22511   22511           
=====================================
  Hits       17829   17829           
  Misses      4682    4682

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cijothomas
cijothomas approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cijothomas cijothomas merged commit d481be5 into open-telemetry:main Feb 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cijothomas cijothomas cijothomas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use opentelemetry::time::now() everywhere

2 participants

@mohammadVatandoost @cijothomas